Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v7 breaking changes megathread #2854

Closed
23 tasks done
fselmo opened this issue Feb 27, 2023 · 15 comments
Closed
23 tasks done

v7 breaking changes megathread #2854

fselmo opened this issue Feb 27, 2023 · 15 comments

Comments

@fselmo
Copy link
Collaborator

fselmo commented Feb 27, 2023

Main thread for tracking breaking changes slated for the next major version release of web3.py - v7. This will be an evolving issue much like #1416 was for v6.

Candidates:

Tasks

  1. Pending Clarification v7
  2. Breaking Change v7
  3. 2 of 2
    v7
  4. v7
  5. priority: p2 important v7
  6. v7
  7. v7
  8. v7
  9. priority: p3 normal v7
    reedsa
  10. v7
  11. priority: p3 normal v7
  12. Breaking Change v7
  13. v7
  14. v7
  15. reedsa
  16. v7
  17. Breaking Change v7
  18. v7
  19. Breaking Change v7
@kclowes
Copy link
Collaborator

kclowes commented Apr 13, 2023

Return ipc path even if it doesn't yet exist. See #2911

@pacrob
Copy link
Contributor

pacrob commented May 10, 2023

Remove the ethPM module, deprecated in #2953

@wolovim wolovim pinned this issue May 15, 2023
@kclowes
Copy link
Collaborator

kclowes commented May 24, 2023

#2964 - Change provider User-Agent header to be more readable.

@kclowes
Copy link
Collaborator

kclowes commented Jun 8, 2023

Better UX for provider-specific middlewares. See: #2770

edit: issue created (#2990)

@reedsa
Copy link
Contributor

reedsa commented Jul 7, 2023

Remove the miner API, deprecated in #2856.

@pacrob
Copy link
Contributor

pacrob commented Jul 10, 2023

Here, then upstream libs:

  • Remove python 3.7 support
  • Branch name change: master -> main

@pacrob
Copy link
Contributor

pacrob commented Sep 21, 2023

AttributeDict updates #3105

@fselmo fselmo unpinned this issue Nov 17, 2023
@fselmo fselmo pinned this issue Nov 17, 2023
@pacrob
Copy link
Contributor

pacrob commented Nov 28, 2023

web3 v7 should set hexbytes>=1.0.0.

Bottom pins for our other libs should move up to at least the release that dropped py37 support

@kclowes
Copy link
Collaborator

kclowes commented Jan 10, 2024

Where possible, have all errors thrown inherit from Web3Exception, or ENSException. See #1864.

@fselmo
Copy link
Collaborator Author

fselmo commented Feb 21, 2024

I updated the task list to include all the commented items in this issue. We can try to add items to the task list in the future so we can keep track of what's done and what isn't.

@fselmo
Copy link
Collaborator Author

fselmo commented Feb 21, 2024

Return ipc path even if it doesn't yet exist. See #2911

@kclowes was this completed with the merging of #2911 ?

@pacrob
Copy link
Contributor

pacrob commented Feb 22, 2024

Return ipc path even if it doesn't yet exist. See #2911

@kclowes was this completed with the merging of #2911 ?

Not done. Just needs the if exists part removed and return the path.

@fselmo
Copy link
Collaborator Author

fselmo commented Apr 26, 2024

All issues that were being tracked here are now completed and released as of 7.0.0-beta.5. There may be other changes added into v7 as we update the library to use newer major versions of dependencies but those can be tracked separately before stable gets released.

@fselmo fselmo closed this as completed Apr 26, 2024
@fselmo fselmo unpinned this issue May 15, 2024
@MathiasExorde
Copy link

Can I see a link explaining the motivation for a major v7 changing lots of things?

@fselmo
Copy link
Collaborator Author

fselmo commented Jul 23, 2024

Can I see a link explaining the motivation for a major v7 changing lots of things?

Hey @MathiasExorde. Each issue here should have its own link, though the migration documentation provides a good summary of it all together. Most of the changes were quite small, though technically breaking. Those have to be aggregated and need to wait until the next major version cycle to be addressed. Some of the bigger changes, like the middleware moving to a class-based architecture, helped close out long-standing tickets such as the ability to batch requests which had been an open issue since 2018. Hope that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants