Remove deprecated personal namespace
#3350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
force-pushed
the
remove-deprecated-personal-namespace
branch
from
794c359 to
b0598af
Compare
fselmo
force-pushed
the
remove-deprecated-personal-namespace
branch
from
b0598af to
61ae400
Compare
- Remove the idea of an ``unlockable_account``. Since we are no longer using an API to "unlock", there's no need to test it. Instead, use the keyfile account as the ``from`` in ``eth_sendTransaction`` and anywhere that an account that is "known" by the node needs to be used. - Set up the keyfile account as the known account for testing.
fselmo
force-pushed
the
remove-deprecated-personal-namespace
branch
from
61ae400 to
5aeb7f2
Compare
fselmo
added a commit
to fselmo/web3.py
that referenced
this pull request
Apr 16, 2024
fselmo
changed the title
personal namespace
fselmo
force-pushed
the
remove-deprecated-personal-namespace
branch
from
2dad79b to
8a47aeb
Compare
fselmo
added a commit
to fselmo/web3.py
that referenced
this pull request
Apr 16, 2024
bonus: re-generate fixture for making sure we have all changes in related to ethereum#3350
fselmo
force-pushed
the
remove-deprecated-personal-namespace
branch
from
07d08d9 to
fa23f25
Compare
- Clean up some unnecessary changes related to removing personal namespace - bonus: re-generate fixture for making sure we have all changes in related to ethereum#3350
fselmo
force-pushed
the
remove-deprecated-personal-namespace
branch
from
fa23f25 to
71407ca
Compare
fselmo
added a commit
that referenced
this pull request
Apr 17, 2024
- Clean up some unnecessary changes related to removing personal namespace - bonus: re-generate fixture for making sure we have all changes in related to #3350
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue #2854
Closes #2844
How was it fixed?
personalnamespace from the codebase and all tests and mentions of it.1.13.14(No Cancun rules still since we are still waiting for devmode support from Geth).Todo:
Cute Animal Picture