Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out what to do with web3.shh, web3.bzz, etc. #802

Closed
pipermerriam opened this issue Apr 30, 2018 · 3 comments
Closed

Figure out what to do with web3.shh, web3.bzz, etc. #802

pipermerriam opened this issue Apr 30, 2018 · 3 comments

Comments

@pipermerriam
Copy link
Member

pipermerriam commented Apr 30, 2018

What is wrong

Right now we have some in-flight functionality for Whisper V6: #784

As it stands, we can write in support for this in web3.shh but I want to figure out a future proof way to do this. I see the following problems coming down the road.

  • API differences between nodes (parity, geth, ...)
  • API differences across protocol versions (v5, v6, v???)

How it could be fixed.

When you have middleware, everything looks like a middleware...??

Dealing with API differences across different nodes is an issue that exists in the eth_ namespace as well. Currently, we can mostly address these with middlewares, or intentionally not address them but raise helpful errors.

Namespace by node

Alternatively we could implement submodules like w3.geth.shh and w3.parity.shh but that adds some development and testing overhead.

Namespace by version

For dealing with actual changes between protocol versions... not clear. Versioning the actual module might make sense, i.e. web3.shh.v6.WhisperModule. Still poses some usability hurdles.

Separate package

We could move web3.shh to it's own package web3-shh and require installation of the separate package and manual addition of the shh module.

@carver
Copy link
Collaborator

carver commented Apr 30, 2018

Meant to link #784 instead of #117 I assume?

Implicit default option punt until the API settles X)

@pipermerriam
Copy link
Member Author

Implicit default option punt until the API settles X)

👍

@wolovim
Copy link
Member

wolovim commented Nov 11, 2020

this is ancient, but:

  • since whisper is abandoned, just ripped it out in this PR: Remove Whisper API #1791
  • swarm could still end up with web3 support in some fashion, but the team is off with their own agenda these days. separate ticket required if necessary.

@wolovim wolovim closed this as completed Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants