Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BACKPORT TO V4] Add timeout for WebsocketProvider #1119

Merged
merged 4 commits into from
Oct 22, 2018
Merged

[BACKPORT TO V4] Add timeout for WebsocketProvider #1119

merged 4 commits into from
Oct 22, 2018

Conversation

voith
Copy link
Contributor

@voith voith commented Oct 19, 2018

What was wrong?

backports #1109 to v4

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

carver
carver approved these changes Oct 19, 2018
View reviewed changes
Copy link
Collaborator

@carver carver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably just a hiccup in CI. Good to merge when green.

@voith
Copy link
Contributor Author

voith commented Oct 20, 2018

all green now!

@carver carver merged commit e3e7510 into ethereum:v4 Oct 22, 2018
@voith voith deleted the v4-add-websocket-timeout branch October 22, 2018 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carver carver carver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@voith @carver