-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable pm api by default #1216
Disable pm api by default #1216
Conversation
) | ||
|
||
def enable_unstable_package_management_api(self): | ||
from web3.pm import PM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the quick and easy solution to avoiding the circular import this time around, but it seems to me like this won't be suitable long-term when we want to make the PM api available on the web3
object by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm missing it: which circular import? Does web3.pm
import from web3.main
somehow?
I don't follow how this will be different from any other modules that are attached on Web3
by default.
773b981
to
8416c8a
Compare
) | ||
|
||
def enable_unstable_package_management_api(self): | ||
from web3.pm import PM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm missing it: which circular import? Does web3.pm
import from web3.main
somehow?
I don't follow how this will be different from any other modules that are attached on Web3
by default.
@carver Sorry, it's not very clear but |
At some point, we may have to vendor |
Disable pm api by default
Disable pm api by default
Disable pm api by default
Disable pm api by default
Disable pm api by default
Disable pm api by default
Disable pm api by default
Disable pm api by default
What was wrong?
Disable
PM
API by default, and mechanism to enable the unstable API.Cute Animal Picture