Deprecate endpoints according to updated spec #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
force-pushed
the
refactor-jsonrpc-endpoints
branch
2 times, most recently
from
b2fb008 to
8bcd127
Compare
|
It doesn't appear these have been properly deprecated in v4. We'll need to do that asap so that users won't be surprised by their disappearance. |
njgheorghita
force-pushed
the
refactor-jsonrpc-endpoints
branch
7 times, most recently
from
69d59b2 to
98cf8d3
Compare
njgheorghita
changed the title
njgheorghita
force-pushed
the
refactor-jsonrpc-endpoints
branch
4 times, most recently
from
f85c88f to
f32c205
Compare
njgheorghita
force-pushed
the
refactor-jsonrpc-endpoints
branch
from
f32c205 to
889c1cf
Compare
pipermerriam
approved these changes
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
RPC endpoints have changed according to new EIP-1474.
web3.net.chainId()web3.eth.getCompilers()web3.eth.getTransactionFromBlock()web3.eth.enableUnauditedFeatures()Cute Animal Picture