Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade eth-account to v0.4 #1348

Merged
merged 3 commits into from
May 7, 2019
Merged

Conversation

carver
Copy link
Collaborator

@carver carver commented May 6, 2019

Update docs, fix backwards-incompatible import.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@carver carver requested a review from njgheorghita May 6, 2019 19:24
@carver
Copy link
Collaborator Author

carver commented May 6, 2019

Note that this should not be backported to web3 v4. Also, I realized as I was updating the docs that the keys in returned dicts are still camel case. Not sure what to do with that. I guess it means including duplicates of the keys (camel case and snake case) in the v0.4 of eth-account, and dropping camel-case in v0.5. I can do that in eth-account v0.4.1, but probably won't get around to it for a bit.

@carver carver force-pushed the eth-account-upgrade branch from 8d8b6fd to 761ad1d Compare May 6, 2019 20:18
@carver carver force-pushed the eth-account-upgrade branch from 761ad1d to e842007 Compare May 6, 2019 20:41
Copy link
Contributor

@njgheorghita njgheorghita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@carver carver merged commit 4180319 into ethereum:master May 7, 2019
@carver carver deleted the eth-account-upgrade branch May 7, 2019 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants