Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for eth_getRawTransactionByHash #2051

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

Moras-del
Copy link
Contributor

@Moras-del Moras-del commented Jun 24, 2021

What was wrong?

RPC method eth_getRawTransactionByHash was not supported. This PR adds support for this method.

Related to Issue #2039

How was it fixed?

Implemented similarly to the method eth_getTransactionByHash

Todo:

  • Proper exception handling (transaction not found, method not supported)

Cute Animal Picture

obraz

@kclowes
Copy link
Collaborator

kclowes commented Jun 28, 2021

Thanks @Moras-del! This is looking good! Since we don't have the getRawTransactionByHash RPC method implemented in eth-tester, you'll want to go in to tests/integration/test_ethereum_tester.py and add an xfail similar to what we do here. Let me know if that doesn't make sense!

@kclowes kclowes force-pushed the add-rpc-method-230621 branch from ab29d8a to c422679 Compare July 9, 2021 22:17
@kclowes
Copy link
Collaborator

kclowes commented Jul 9, 2021

Thanks for getting this rolling @Moras-del! I made some updates and will do a final check before merging, probably on Monday!

@kclowes kclowes changed the title [WIP] Add support for eth_getRawTransactionByHash Add support for eth_getRawTransactionByHash Jul 9, 2021
@kclowes kclowes force-pushed the add-rpc-method-230621 branch 3 times, most recently from 2237fd8 to 3cc4a88 Compare July 13, 2021 04:24
@fselmo fselmo force-pushed the master branch 2 times, most recently from 5ef554e to 1417eb8 Compare July 13, 2021 17:04
@kclowes kclowes force-pushed the add-rpc-method-230621 branch from 3cc4a88 to f73b8e5 Compare July 14, 2021 16:37

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@kclowes kclowes force-pushed the add-rpc-method-230621 branch from f73b8e5 to af5af98 Compare July 14, 2021 17:23
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@kclowes kclowes merged commit 4893947 into ethereum:master Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants