Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2259, remove dependency on eth_maxPriorityFeePerGas #2276

Merged
merged 4 commits into from
Feb 1, 2022
Merged

Fixes #2259, remove dependency on eth_maxPriorityFeePerGas #2276

merged 4 commits into from
Feb 1, 2022

Commits on Feb 1, 2022

  1. Fixes ethereum#2259, remove dependency on eth_maxPriorityFeePerGas

    @broper2 @fselmo
    broper2 authored and fselmo committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    cf47f0c View commit details
    Browse the repository at this point in the history

  2. fix lint and integration tests

    @broper2 @fselmo
    broper2 authored and fselmo committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    8c3c7a4 View commit details
    Browse the repository at this point in the history

  3. refactor: utility for estimating maxPriorityFeePerGas via eth_feeHistory 

    Refactor idea from PR ethereum#2259 into sync and async fee utility methods. Change params passed into eth_feeHistory to values that allowed for better results when we tested locally. Add a min and max to the estimated fee history so that we don't allow unsuspecting users to contribute to fee bloating. Max and min values keep the priority fee within a range that healthy blocks should accept, so these transactions would be accepted when fee prices settle from high-fee periods.
    @fselmo
    fselmo committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    7addd65 View commit details
    Browse the repository at this point in the history

  4. add tests for max_priority_fee when eth_maxPriorityFeePerGas is not a… 

    …vailable
    @fselmo
    fselmo committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    9b3532b View commit details
    Browse the repository at this point in the history