Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove auto provider except for local geth dev #2706

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Nov 2, 2022

What was wrong?

Related to issue #1416
closes #1736?

How was it fixed?

  • We decided the overhead of setting up your own provider is not much and is ultimately more transparent for the user.
  • Keep around geth --dev auto provider as that connects locally and not to any external provider service.

Todo:

  • Add entry to the release notes
  • Consider dropping the geth --dev auto provider altogether? [keeping it]

Cute Animal Picture

17

@fselmo fselmo mentioned this pull request Nov 2, 2022
22 tasks
@fselmo fselmo force-pushed the remove-auto-provider branch 2 times, most recently from e491ce4 to c819935 Compare November 19, 2022 01:06
@fselmo fselmo changed the title [WIP] Remove auto provider except for local geth dev Remove auto provider except for local geth dev Nov 19, 2022
- Remove support for and references to infura auto provider
@fselmo fselmo marked this pull request as ready for review November 19, 2022 01:11
@pacrob
Copy link
Contributor

pacrob commented Nov 21, 2022

As discussed, docs/web3.auto.infura.rst should be removed.

fselmo added a commit to fselmo/web3.py that referenced this pull request Nov 21, 2022
- ``git rm --cached docs/web3.auto.infura.rst``
@pacrob
Copy link
Contributor

pacrob commented Nov 21, 2022

As discussed, docs/web3.auto.infura.rst should be removed.

nm, was a local issue. GTG!

Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fselmo fselmo merged commit af2f559 into ethereum:master Nov 21, 2022
@fselmo fselmo deleted the remove-auto-provider branch April 3, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autoprovider repo template
2 participants