Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ipfshhtpclient an optional library / backend for ethpm #2730

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Nov 22, 2022

What was wrong?

How was it fixed?

  • Make ipfshttpclient optional as a web3 install extra.

Todo:

Cute Animal Picture

2672_71140428065_621963065_2212139_181618_n

@fselmo fselmo force-pushed the make-ipfsclient-optional branch 2 times, most recently from 30bc908 to b5dc79a Compare November 22, 2022 21:01
@fselmo fselmo changed the title [WIP] Make ipfshhtpclient an optional library / backend for ethpm Make ipfshhtpclient an optional library / backend for ethpm Nov 22, 2022
- This change affects the different ipfs backends of ethpm.
- Update docs to reference how to install the optional web3 install extra to utilize the ipfs backends.
@fselmo fselmo marked this pull request as ready for review November 22, 2022 21:32
@fselmo fselmo mentioned this pull request Nov 22, 2022
22 tasks
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally and it looks good to me! :shipit:

@fselmo fselmo merged commit e975451 into ethereum:master Nov 28, 2022
@fselmo fselmo deleted the make-ipfsclient-optional branch April 3, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ipfshttpclient is unmaintained
3 participants