Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic support of batch requests to AsyncHTTPProvider #3102

Closed
wants to merge 2 commits into from

Conversation

dmkulazhenko
Copy link
Contributor

Related to Issue #832

This PR contains basic/limited support of batch requests for AsyncHTTPProvider.


Problem with batch requests is living there for years... and to be honest, there is a lot of things to do to add support of batch requests 😢. With this PR I just want to add stuff that is critical for me... and praying that it will motivate someone to finally resolve #832.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@dankvul
Copy link

dankvul commented Oct 18, 2023

@fselmo looks like useful stuff at least for beginning, could you review please?

@lilcryptopump
Copy link

I need this 👀

@fselmo
Copy link
Collaborator

fselmo commented Nov 3, 2023

I've been taking a look here recently and, though this will require some non-trivial refactoring to the code base, it seems like it's not too far off the table for a v7 implementation. I'll be sure to update here and implement on top of this PR to give credit where it's due. However, merging this in as it stands is not ideal since changes to these methods would cause breaking changes with each iteration.

@fselmo
Copy link
Collaborator

fselmo commented May 10, 2024

This was cherry-picked in #3370 and merged. Thanks for getting it going @dmkulazhenko !

@fselmo fselmo closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Perform batch RPC requests to ethereum node
4 participants