add abi.decode strictness flag and catch InsufficientDataBytes error … #3256
+128
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…when parsing logs
This should use the existing global strictness flag.
What was wrong?
Related to Issue #1441 , if a user is decoding logs with length not a multiple of 32 bytes, it throws an
eth-abi
InsufficientBytesLength
error which is not properly caught.How was it fixed?
Add catching the error type
InsuffiecientDataBytes
and allow the passing ofstrict
flag through toeth_abi.decode
inprocess_receipt
.Since the flag is then passed to
get_event_data
, I considered making the flag available everywhereget_event_data
is called, but that would greatly expand the scope and doesn't seem necessary, given the original issue.Todo:
Cute Animal Picture