Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate geth.personal namespace methods #3364

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Apr 25, 2024

What was wrong?

geth.personal is removed in v7. Deprecate in v6.

Related to Issue #2844

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

Screenshot 2024-04-25 at 10 59 38

@fselmo fselmo force-pushed the v6-deprecate-geth-personal-namespace branch from 808e9a3 to b2a9f99 Compare April 25, 2024 17:08
@fselmo fselmo marked this pull request as ready for review April 25, 2024 17:08
@fselmo fselmo requested review from kclowes, pacrob and reedsa April 25, 2024 17:08
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

web3/method.py Outdated Show resolved Hide resolved
@fselmo fselmo force-pushed the v6-deprecate-geth-personal-namespace branch from b2a9f99 to e69560d Compare April 25, 2024 19:44
@fselmo fselmo merged commit efe41ef into ethereum:v6 Apr 25, 2024
10 of 99 checks passed
@fselmo fselmo deleted the v6-deprecate-geth-personal-namespace branch April 25, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants