Some optimizations for JSON #3498
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fwiw, i think there are some things in this PR that might want to be picked up here, like making the web3.providers.auto not circular importing on web3.providers, even if some of the other bits are not wanted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Closes #3496
How was it fixed?
This makes some modest changes to JSON, to squeeze out some spaces, get rid of some unnecessary object instantiation. added some test cases because JSONBaseProvider was tested, not AsyncJSONBaseProvider. The big issue I wanted to solve was to send text to websockets package, so the logging there would be in text, and not binary (see issue). But i didn't change Legacy for that, which still is bytes.
Todo:
Cute Animal Picture