Fix tuple input types in base contract #3754
Open
+206
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
argument_typesin the base contract were initialised incorrectly for tuples.If you revert the changes in the
base_contract.py, then the newly added tests will fail on the following error:How was it fixed?
Using the existing
collapse_if_tuplefunction on the input, instead of just taking the rawtypefield from the dictionary.Todo:
Cute Animal Picture