Skip to content

Conversation

@kongzii
Copy link

@kongzii kongzii commented Sep 12, 2025

What was wrong?

argument_types in the base contract were initialised incorrectly for tuples.

If you revert the changes in the base_contract.py, then the newly added tests will fail on the following error:

E               AssertionError: assert ('tuple',) == ('(uint256,ui...dress[])[])',)
E                 
E                 At index 0 diff: 'tuple' != '(uint256,uint256[],(int256,bool[2],address[])[])'
E                 
E                 Full diff:
E                   (
E                 -     '(uint256,uint256[],(int256,bool[2],address[])[])',
E                 +     'tuple',
E                   )

How was it fixed?

Using the existing collapse_if_tuple function on the input, instead of just taking the raw type field from the dictionary.

Todo:

  • Clean up commit history
  • (not needed) Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant