Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

wiki: eth_pendingTransactions documentation lacks 'for managed addresses' caveat #685

Open
meowsbits opened this issue Jan 8, 2020 · 1 comment

Comments

@meowsbits
Copy link

System information

Geth version: any from at least last few years

Expected behaviour

eth_pendingTransactions returns all transactions marked as pending in the transaction pool, as documented here: https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_pendingtransactions

__eth_pendingTransactions__

Returns the pending transactions list.

Actual behaviour

eth_pendingTransactions returns pending transactions sent from accounts managed by geth instance.

Proposed Solution

Fix documentation to read:

__eth_pendingTransactions__

Returns the transactions that are pending in the transaction pool and have a from address that is one of the accounts this node manages.

https://github.com/ethereum/go-ethereum/blob/master/internal/ethapi/api.go#L1582-L1584

@ChrisChinchilla ChrisChinchilla self-assigned this Jan 15, 2020
@ChrisChinchilla ChrisChinchilla removed their assignment Jul 31, 2020
@artob
Copy link

artob commented Apr 16, 2021

Linking to the previous Geth issue: ethereum/go-ethereum#20523

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants