Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wiki: eth_pendingTransactions documentation lacks 'for managed addresses' caveat #20523

Closed
meowsbits opened this issue Jan 7, 2020 · 1 comment

Comments

@meowsbits
Copy link
Contributor

System information

Geth version: any from at least last few years

Expected behaviour

eth_pendingTransactions returns all transactions marked as pending in the transaction pool, as documented here: https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_pendingtransactions

__eth_pendingTransactions__

Returns the pending transactions list.

Actual behaviour

eth_pendingTransactions returns pending transactions sent from accounts managed by geth instance.

Proposed Solution

Fix documentation to read:

__eth_pendingTransactions__

Returns the transactions that are pending in the transaction pool and have a from address that is one of the accounts this node manages.

https://github.com/ethereum/go-ethereum/blob/master/internal/ethapi/api.go#L1582-L1584

meowsbits added a commit to etclabscore/ethereum-json-rpc-specification that referenced this issue Jan 7, 2020
@karalabe
Copy link
Member

karalabe commented Jan 8, 2020

Please open the issue on the wiki repo https://github.com/ethereum/wiki/issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants