-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spurious dragon changes #198
Conversation
b8ee497
to
4774b75
Compare
@gavofyork @chriseth What is the next step here? |
Paper.tex
Outdated
@@ -41,7 +41,7 @@ | |||
\newcommand*\ie{i.e.\@\xspace} | |||
%\renewcommand{\itemhook}{\setlength{\topsep}{0pt} \setlength{\itemsep}{0pt}\setlength{\leftmargin}{15pt}} | |||
|
|||
\title{Ethereum: A Secure Decentralised Generalised Transaction Ledger \\ {\smaller \textbf{EIP-150 revision (\YellowPaperVersionNumber{})}}} | |||
\title{Ethereum: A Secure Decentralised Generalised Transaction Ledger \\ {\smaller \textbf{EIP-170 revision (\YellowPaperVersionNumber{})}}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
155/160/161 changes, no?
Paper.tex
Outdated
\quad\equiv\quad \boldsymbol{\sigma}[a] = \varnothing \vee \mathtt{\tiny EMPTY}(\boldsymbol{\sigma}, a) | ||
\end{equation} | ||
|
||
Here is a function that updates the balance of an account state but deletes the account state when it becomes empty: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Here is a" -> "We define the"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes requested from Initial review. Will do deeper review later.
These EIPs were applied on the same block number, so it makes sense to list them all.
4fbbfa6
to
e0b412b
Compare
e0b412b
to
e55d83f
Compare
I fixed these points. |
Paper.tex
Outdated
(\boldsymbol{\sigma}[a]_n, x, \boldsymbol{\sigma}[a]_s, \boldsymbol{\sigma}[a]_c) \quad \text{otherwise} | ||
\end{cases} | ||
\end{equation} | ||
for $a \in \mathbb{B}_{20}$ and $x \in \mathbb{P}_{256}$. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"for" -> "where"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks mostly good. just a couple of issues.
Paper.tex
Outdated
\end{equation} | ||
\begin{align} | ||
c \equiv \begin{cases} | ||
2^{256} - 1 & \text{if} \quad |\mathbf{o}| \le 24000 \\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be 24576
@gavofyork thanks. I fixed these two points. |
I tried to capture the "Spurious Dragon" changes.