Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metroplis: EIP 101 big-modexp precompile #268

Closed
wants to merge 21 commits into from

Conversation

pirapira
Copy link
Member

If merged, this would solve #235 as part of the Metropolis changes #229.

This is a re-incarnation of #258. Comments given there are addressed.

@pirapira pirapira mentioned this pull request Mar 22, 2017
12 tasks
@axic
Copy link
Member

axic commented Mar 23, 2017

I wonder if it would make sense including the accepted EIP numbers next to the precompiles? Sort of keeping a history which EIP introduced a certain change.

@pirapira
Copy link
Member Author

pirapira commented Mar 23, 2017

@axic I'll discuss that with @gavofyork when I see him next time. [EDIT: which is today March 30 2017]

@gavofyork
Copy link
Contributor

i think the EIP process is documentation enough - YP is meant as a clean expression of the current state of the Ethereum protocol, not a chronicle of how it got there.

@pirapira pirapira changed the title EIP 101: big-int precompiles [WIP] EIP 101: big-int precompiles Apr 24, 2017
@pirapira pirapira changed the title [WIP] EIP 101: big-int precompiles [WIP] Metroplis: EIP 101 big-int precompiles May 8, 2017
@pirapira pirapira changed the title [WIP] Metroplis: EIP 101 big-int precompiles [WIP] Metroplis: EIP 101 big-expmod precompile May 10, 2017
@pirapira
Copy link
Member Author

The commit history should be cleaned, but as a precaution against EIP changes before Metropolis, some intermediate commits are still left.

@pirapira pirapira changed the title [WIP] Metroplis: EIP 101 big-expmod precompile Metroplis: EIP 101 big-expmod precompile Jun 6, 2017
@pirapira pirapira changed the title Metroplis: EIP 101 big-expmod precompile Metroplis: EIP 101 big-modexp precompile Jul 24, 2017
@pirapira
Copy link
Member Author

This PR should now target master because now master is the Byzantium branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants