\hypertarget{JUMP}{JUMP}, \hypertarget{JUMPI}{JUMPI} and \label{eq:mu_pc} #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirapira
reviewed
Jan 24, 2018
Paper.tex
Outdated
| @@ -1020,7 +1020,7 @@ \subsection{The Execution Cycle} | |||
|
|
|||
| The gas is reduced by the instruction's gas cost and for most instructions, the program counter increments on each cycle, for the three exceptions, we assume a function $J$, subscripted by one of two instructions, which evaluates to the according value: | |||
| \begin{eqnarray} | |||
| \quad \boldsymbol{\mu}'_{g} & \equiv & \boldsymbol{\mu}_{g} - C(\boldsymbol{\sigma}, \boldsymbol{\mu}, I) \\ | |||
| \quad \boldsymbol{\mu}'_{g} & \equiv & \boldsymbol{\mu}_{g} - C(\boldsymbol{\sigma}, \boldsymbol{\mu}, I) \hypertarget{JUMP}{JUMP} \hypertarget{JUMPI}{JUMPI} \label{eq:mu_pc}\\ | |||
There was a problem hiding this comment.
I'd expect JUMP and JUMPI jumps to those in the instruction table.
jamesray1
changed the title
pirapira
suggested changes
Jan 29, 2018
…nkdest where not in text mode
pirapira
suggested changes
Jan 30, 2018
Paper.tex
Outdated
| @@ -951,7 +951,8 @@ \subsubsection{Exceptional Halting} | |||
| \boldsymbol{\mu}_g < C(\boldsymbol{\sigma}, \boldsymbol{\mu}, I) \quad \vee \\ | |||
| \mathbf{\delta}_w = \varnothing \quad \vee \\ | |||
| \lVert\boldsymbol{\mu}_\mathbf{s}\rVert < \mathbf{\delta}_w \quad \vee \\ | |||
| ( w \in \{ \text{\small JUMP}, \text{\small JUMPI} \} \quad \wedge \\ \quad \boldsymbol{\mu}_\mathbf{s}[0] \notin D(I_\mathbf{b}) ) \quad \vee \\ | |||
| ( w \in \{ \text{\small JUMP}, \text{\small | |||
There was a problem hiding this comment.
Must be an oversight.
pirapira
reviewed
Jan 30, 2018
Paper.tex
Outdated
| @@ -2082,11 +2082,11 @@ \subsection{Instruction Set} | |||
| 0 & \text{otherwise} | |||
| \end{cases}$ \\ | |||
| \midrule | |||
| 0x56 & {\small JUMP} & 1 & 0 & Alter the program counter. \\ | |||
| \linkdest{JUMP}{JUMP}0x56 & {\small JUMP} & 1 & 0 & Alter the program counter. \\ | |||
There was a problem hiding this comment.
The second argument should be empty.
pirapira
suggested changes
Jan 30, 2018
Paper.tex
Outdated
| \midrule | ||
| 0x57 & {\small JUMPI} & 2 & 0 & Conditionally alter the program counter. \\ | ||
| \linkdest{JUMPI}0x57 & {\small JUMPI} & 2 & 0 & Conditionally alter the program counter. \\ |
There was a problem hiding this comment.
There should be a {} as a second argument. Currently, the first 0 in 0x57 is considered the link target.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.