Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The up-front cost hyperlinks #561

Merged
merged 2 commits into from
Feb 13, 2018
Merged

The up-front cost hyperlinks #561

merged 2 commits into from
Feb 13, 2018

Conversation

jamesray1
Copy link
Contributor

It's pretty simple anyway but nevertheless...

@jamesray1
The up-front cost hyperlinks
84cf2eb 
It's pretty simple anyway but nevertheless...
pirapira
pirapira suggested changes Feb 8, 2018
View reviewed changes
Copy link
Member

@pirapira pirapira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of English pronunciation of the formula is too verbose, I think.

@jamesray1
Copy link
Contributor Author

Or not terse enough, perchance?

pirapira
pirapira approved these changes Feb 13, 2018
View reviewed changes
Copy link
Member

@pirapira pirapira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@pirapira pirapira merged commit c627a52 into ethereum:master Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirapira pirapira pirapira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesray1 @pirapira