-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve spec of MLOAD, MSTORE, and MSIZE. #775
base: master
Are you sure you want to change the base?
Conversation
This is in reference to Issue ethereum#767, which has all the relevant discussion. ethereum#767
Co-authored-by: Daniel Kirchner <daniel@ekpyron.org>
@ekpyron Yes, definitely, thanks for catching it. |
@nicksavers Does this look good to you too? If you confirm, you or I can merge it. Thanks. |
This limit has been a topic of discussion before. There is EIP-1985: Sane limits for certain EVM parameters and Geth (and some others) have already implemented a different value for MSIZE. You are free to take those values for your interpreter or add your input in the discussion thread. I suggest not to merge this until the EIP is Final. |
@nicksavers Waiting for the EIP to be final is fine with me. (We could still fix the overflow problem found by @ekpyron for the time being, even though it's a theoretical case, and then further revise things when the EIP is final. But perhaps we want to avoid too many revisions, especially if the EIP may be finalized soon(?).) |
IMHO we should merge and fix this independently of that EIP. |
@nicksavers I think this is independent from EIP-1985. This PR fixes an ambiguity (stack items are 256-bit wide so the offset can be at most 2^256-1), while EIP-1985 introduces stricter limits (which I think should definitely be applied to the YP once the EIP is accepted). |
This is in reference to Issue #767, which has all the relevant discussion.
This changes
and
to
and