Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny Correction for returndata in Create #881

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ritzdorf
Copy link

Based on the definition of z above, where it is z = 0 in the error case, I think it should be z = 0 instead of z = 1 in this part as well. Alternatively, the whole line could simplified as

$\boldsymbol{\mu}'_{\mathbf{o}} = \mathbf{o}$

Based on the definition of z above, where it is 0 in the error case, I think it should be z = 0 instead of z = 1. Alternatively, it could simplified as 
```
$\boldsymbol{\mu}'_{\mathbf{o}} = \mathbf{o}$
```
@yperbasis
Copy link
Member

This bit of the YP is not very clear, but I think the logic is that the output is returned in the case of REVERT and is not returned in the case of success. See EIP-140 and https://github.com/ethereum/go-ethereum/blob/v1.10.26/core/vm/instructions.go#L618.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants