Skip to content
This repository has been archived by the owner on Dec 10, 2020. It is now read-only.

Upgrade official Ethash tests / Remove ethereumjs-testing dependency #21

Closed
holgerd77 opened this issue May 26, 2020 · 0 comments · Fixed by #23
Closed

Upgrade official Ethash tests / Remove ethereumjs-testing dependency #21

holgerd77 opened this issue May 26, 2020 · 0 comments · Fixed by #23

Comments

@holgerd77
Copy link
Member

Tests should be upgraded to the latest test state from the ethereum/tests repository (not sure if necessary though since tests are not updated there for quite some time as well).

Along the ethereumjs-testing dependency should be removed analogue to e.g. ethereumjs/ethereumjs-block#61, since the dependency is super-heavy (several 100 MBs) and the tests rarely change.

This would be a pre-requisite for #20 (the monorepo part), since we don't want to draw in this dependency within the monorepo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant