Skip to content
This repository has been archived by the owner on Dec 10, 2020. It is now read-only.

Upgrade CI to GH Actions #23

Merged
merged 1 commit into from
May 26, 2020
Merged

Upgrade CI to GH Actions #23

merged 1 commit into from
May 26, 2020

Conversation

ryanio
Copy link
Contributor

@ryanio ryanio commented May 26, 2020 •
edited
Loading

This PR:

  1. Upgrades CI from travis to GH Actions
    1. node versions tested updated from [4, 5] to [10, 12, 13, 14]
  2. Upgrades dev deps (ethereumjs-block, nyc, standard)
  3. Adds ethash_tests.json to test dir and removes ethereumjs-testing dep
  4. Uses single imports for ethereumjs-util, upgrades to v7.0.2
  5. Modernizes buffer init syntax

Closes #21, partially #20

@coveralls
Copy link

coveralls commented May 26, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.3%) to 88.732% when pulling aee38f4 on upgrade-ci-to-gh-actions into df2644b on master.

@ryanio ryanio force-pushed the upgrade-ci-to-gh-actions branch 2 times, most recently from b077541 to 40ae2e3 Compare May 26, 2020 18:23
@ryanio ryanio mentioned this pull request May 26, 2020
Closed
@ryanio
upgrade ci provider to github actions
aee38f4 
upgrade dev deps (ethereumjs-block, nyc, standard)
remove ethereumjs-testing and move ethash_tests.json into test dir
use single imports for ethereumjs-util, upgrade to v7.0.2
@holgerd77
Copy link
Member

Oh, just fixing everything at once, that's great! 😀

holgerd77
holgerd77 approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerd77 holgerd77 merged commit 06b031e into master May 26, 2020
@holgerd77 holgerd77 deleted the upgrade-ci-to-gh-actions branch May 26, 2020 20:37
@holgerd77 holgerd77 mentioned this pull request May 27, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
PR state: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade official Ethash tests / Remove ethereumjs-testing dependency
3 participants
@ryanio @coveralls @holgerd77