This repository has been archived by the owner on Oct 30, 2024. It is now read-only.
Rebase on master "solidity pack arrays" + fixes #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… size Also, split test cases into different 'describes' and address lint issues.
holgerd77
approved these changes
Aug 11, 2019
| return ABI.solidityHexValue(subType, v, 256) | ||
| }) | ||
| return Buffer.concat(arrayValues) | ||
| } else if (type === 'bytes') { |
There was a problem hiding this comment.
Ok, did also some line-by-line review of the isArray part here and some manual tests. Since this is already some reviewed write-up of an existing PR and solid new tests are added and passing I think I can give this a go. Thanks @djrtwo for submitting and @alex-forshtat-tbk for putting this along the finish line. 😄
|
Thank you, I was banging my head against the keyboard trying to understand why hashing arrays wasn't working. I had to install this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR #47 rebased on top of the current master branch with some minor changes to it.
@djrtwo @holgerd77 please review.