Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

Fix browserify issue #40

Merged
merged 2 commits into from
Feb 15, 2018
Merged

Fix browserify issue #40

merged 2 commits into from
Feb 15, 2018

Conversation

holgerd77
Copy link
Member

Adresses #39

@holgerd77 holgerd77 force-pushed the fix-browserify-issue branch from 0f9e7c4 to 0dde6b3 Compare January 30, 2018 11:49
@coveralls
Copy link

coveralls commented Jan 30, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 70.213% when pulling 0dde6b3 on fix-browserify-issue into 01f63d5 on master.

@holgerd77 holgerd77 requested review from axic and jwasinger January 31, 2018 21:20
@holgerd77 holgerd77 changed the title [WIP] Fix browserify issue Fix browserify issue Jan 31, 2018
@holgerd77 holgerd77 requested a review from Silur February 2, 2018 09:30
@axic
Copy link
Member

axic commented Feb 2, 2018

I don't know enough about babel and karma to review this.

@holgerd77 holgerd77 requested a review from fanatid February 2, 2018 10:08
@holgerd77
Copy link
Member Author

@axic Ok, also requested reviews from @Silur and/or @fanatid.

@mitra42
Copy link

mitra42 commented Feb 15, 2018

Would be great to get this merged, its blocking updates on packages that depend on ethereumjs - even indirectly (like IPFS)

@holgerd77
Copy link
Member Author

Will merge without review since I don't find a reviewer and PR is urgent.

@holgerd77 holgerd77 merged commit b1846b6 into master Feb 15, 2018
@holgerd77 holgerd77 deleted the fix-browserify-issue branch February 15, 2018 19:03
@alanshaw
Copy link

Any chance this change can be made to ethereumjs-util as well?

@holgerd77 holgerd77 mentioned this pull request Feb 20, 2018
Merged
@holgerd77
Copy link
Member Author

@alanshaw ethereumjs/ethereumjs-util#119

@holgerd77
Copy link
Member Author

@alanshaw Could you please review this?

@harrshasri harrshasri mentioned this pull request Feb 24, 2018
Merged
@alanshaw alanshaw mentioned this pull request Feb 26, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@axic axic Awaiting requested review from axic

@jwasinger jwasinger Awaiting requested review from jwasinger

@Silur Silur Awaiting requested review from Silur

@fanatid fanatid Awaiting requested review from fanatid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@holgerd77 @coveralls @axic @mitra42 @alanshaw @wanderer