Deprecates callback style interface. #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gets rid of the legacy style examples. If you want callback style, use one of the many promise<->callback wrappers on the internet (though I strongly recommend just using async/await instead).
|
You monster!!!!! |
|
Note: You can grab version 4.0.0 if you want everything except this deprecation warning. Be aware that you won't get future updates until you accept the deprecation though. 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets rid of the legacy style examples and adds a deprecation warning to the callback style entrypoints.
If you want callback style, use one of the many promise<->callback wrappers on the internet (though I strongly recommend just using async/await instead).
This change is being made because maintaining two interfaces is more expensive than maintaining one, and the legacy interface really shouldn't be used now that async/await is available everywhere (all major browsers and LTS version of NodeJS).