Switches to using new eth_getLogs by blockHash RPC. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves a major source of pain with Blockstream, though it does mean that it depends on very new versions of Geth/Parity that have this functionality.
…` rather than throwing an error. `parseInt` is terrible and refuses to ever throw if something goes wrong, instead preferring to return "something reasonable" (which often times is completely unreasonable). This change doesn't solve all of parseInt's problems, but it at least stops it from returning `NaN` or `Infinity`.
epheph
approved these changes
Oct 3, 2018
|
I actually don't know the versions. I hear it is in geth stable and parity beta at the moment, but I haven't verified personally. |
|
Added section to README |
|
@MicahZoltu ganache support still in development |
|
Big fan @epheph. This is currently available via @nionis Think you can get support in |
|
@MicahZoltu I am not working on it, but here is the issue trufflesuite/ganache#136 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves a major source of pain with Blockstream, though it does mean that it depends on very new versions of Geth/Parity that have this functionality.