Skip to content
This repository has been archived by the owner on Dec 10, 2020. It is now read-only.

Added JSON-RPC documentation to README #124

Merged
merged 1 commit into from
Jun 8, 2020
Merged

Conversation

holgerd77
Copy link
Member

Depends on #122

Took the occasion while having a first look into #122 and #123 to write up some JSON-RPC documentation here since I found it extremely hard on a first run to get some requests going.

This technically depends on #122 since it gives the ability to leave the param parameter for a call a short mention (I kept the with-empty-param as default to also showcase the syntax for this case, e.g. for a programmatic usage). Won't give this a "Blocked" label though since this is such a side-note here.

@github-actions
Copy link

github-actions bot commented Jun 8, 2020

Coverage Status

Coverage increased (+0.5%) to 92.711% when pulling 602bcdd on add-jsonrpc-readme into f15259a on master.

Copy link
Contributor

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, this was much needed!

@ryanio
Copy link
Contributor

ryanio commented Jun 8, 2020

overall I'd say the readme is getting a little long so in the future it may be nice to break sections into smaller md files and link to them.

@holgerd77 holgerd77 merged commit f152da1 into master Jun 8, 2020
@holgerd77 holgerd77 deleted the add-jsonrpc-readme branch June 8, 2020 17:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants