This repository has been archived by the owner on Dec 10, 2020. It is now read-only.
Add eth_protocolVersion and modularize createNode in tests #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpulim
reviewed
Dec 11, 2018
| @@ -84,7 +84,7 @@ class EthereumService extends Service { | |||
| * Returns all protocols required by this service | |||
| * @type {Protocol[]} required protocols | |||
| */ | |||
| protocols () { | |||
| get protocols () { | |||
There was a problem hiding this comment.
Yeah, this should just be a getter... good catch
|
Referencing #17 to keep track |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
eth_protocolVersion.Also abstracting the
createNodefunction to the test helpers file, because every RPC test calls the function and it's best not to repeat its implementation in every RPC test.