Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

Use CLI scripts from ethereumjs-config in package.json #43

Merged
merged 1 commit into from
Jan 29, 2019

Conversation

holgerd77
Copy link
Member

Ok, wanted to do this short-term PR to have some more confirmation that the new CLI commands actually works, they do. 😄

Realized now with some more distant look that it would be good to have the original command exposed, currently only the command name from config is displayed (before/after):

$ npm run build

> ethereumjs-common@1.0.0 build PATH/EthereumJS/ethereumjs-common
> tsc -p ./tsconfig.prod.json

$ npm run build

> ethereumjs-common@1.0.0 build PATH/EthereumJS/ethereumjs-common
> ethereumjs-config-build

Will directly address in a short PR on config.

@holgerd77 holgerd77 requested a review from s1na January 29, 2019 10:56
Copy link
Contributor

@s1na s1na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Tested locally, works well!

@holgerd77
Copy link
Member Author

Addressed this in ethereumjs/ethereumjs-config#17.

@holgerd77 holgerd77 merged commit 922da21 into master Jan 29, 2019
@holgerd77 holgerd77 deleted the use-cli-scripts-from-config-packages branch January 29, 2019 11:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants