Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

New release v1.2.0 #52

Merged
merged 1 commit into from
May 28, 2019
Merged

New release v1.2.0 #52

merged 1 commit into from
May 28, 2019

Conversation

holgerd77
Copy link
Member

No description provided.

@holgerd77 holgerd77 requested review from alcuadrado and s1na May 27, 2019 21:23
@s1na
Copy link
Contributor

s1na commented May 28, 2019

On second thought, seems to me that doing a release with only place-holder values for the HF can be somewhat confusing. I wonder if we can for example use ethereumjs-common's master branch (with the merged #51) for testing and release 1.2.0 with full Istanbul release? Or do you see a strong case for doing the release now and working towards a complete support in multiple minor releases?

@holgerd77
Copy link
Member Author

@s1na I think we'll likely run into caching problems if we just use master. I would also like to release draft Istanbul libraries early on for experimentation, since the final Istanbul version is still months away, and in the official library releases I wouldn't want to use master Common version as dependency.

So I still have a strong tendency to do these as official releases. The Common library is just used by us anyhow.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@s1na s1na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As pointed out by @holgerd77, this library is mostly used internally, and the changelog clearly states that this is only draft support for Istanbul.

Let the great Istanbul HF integration begin 😄

@holgerd77 holgerd77 merged commit 351aef9 into master May 28, 2019
@holgerd77 holgerd77 deleted the new-release-v120 branch May 28, 2019 10:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants