This repository has been archived by the owner on Oct 30, 2024. It is now read-only.
Rename packages (nyc -> coverage, prettier -> format, tsc -> typescript) #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evertonfraga
approved these changes
May 19, 2020
There was a problem hiding this comment.
LGTM!
I pushed some more README changes, and renamed the typescript files, trying to distance ourselves from the tsc name.
Please double-check my work, @ryanio.
ryanio
commented
May 19, 2020
| "tsc": "ethereumjs-config-tsc", | ||
| "build": "ethereumjs-config-build" | ||
| "tsc": "ethereumjs-config-ts-compile", | ||
| "build": "ethereumjs-config-ts-build" |
|
thanks for those, looks great! |
|
I looked at past PRs, and it seems we can safely ignore LGTM analysis for JS. Merging in… |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #26 (comment) and to close #18, this PR renames:
ethereumjs-config-nyc->ethereumjs-config-coverageethereumjs-config-prettier->ethereumjs-config-formatethereumjs-config-tsc->ethereumjs-config-ts-compileethereumjs-config-build->ethereumjs-config-ts-buildethereumjs-config-tslintis renamed toethereumjs-config-lintin #26.This PR also removes coveralls since we can now push reports via github actions (closes #22).