Skip to content
This repository has been archived by the owner on Oct 30, 2024. It is now read-only.

Removing format package #33

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Removing format package #33

merged 1 commit into from
Aug 26, 2020

Conversation

evertonfraga
Copy link
Contributor

Given that now we're using Prettier as a plugin of ESLint in our lint package, I believe we should retire the @ethereumjs/config-format package, which sole objective was to run Prettier in check and fix modes.

We haven't changed much in the format package lately, so I had never fully wrapped my head around it. Once I did, 💣💥.

@ryanio
Copy link
Contributor

ryanio commented Aug 26, 2020

sounds good 👍 can eslint run prettier fix then? that’s great

@evertonfraga
Copy link
Contributor Author

Yes!

if you run eslint with the --fix flag, your code will be formatted according to prettier style.

Source: https://github.com/prettier/eslint-plugin-prettier

Copy link
Contributor

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@evertonfraga evertonfraga merged commit 24a2c1a into master Aug 26, 2020
@evertonfraga evertonfraga deleted the remove-format-package branch August 26, 2020 17:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants