Upgrade deps (config 2.0, monorepo betas, typedoc) #93
Conversation
| project: ['./tsconfig.json'] | ||
| }, | ||
| rules: { | ||
| '@typescript-eslint/no-floating-promises': 'off', |
There was a problem hiding this comment.
There seems to be some floating promises that I didn't have the time to resolve yet, I didn't want to make too broad changes from sync to async funcs. The primary problem for this seems to be the addPeer promise in a few places.
| }, | ||
| rules: { | ||
| '@typescript-eslint/no-floating-promises': 'off', | ||
| 'no-redeclare': 'off' |
There was a problem hiding this comment.
I turned this off for now as the only problem here was duplication of names in the "export namespace" for ETH, LES.
It seems like we can solve this with setting ignoreDeclarationMerge to true, but that option seems to only be available in the rule for typescript-eslint/no-redeclare where here we are using the base no-redeclare and I didn't want to add the typescript-eslint module just to add that rule. The config would look something like this:
{
// note you must disable the base rule as it can report incorrect errors
"no-redeclare": "off",
"@typescript-eslint/no-redeclare": ["error", { ignoreDeclarationMerge: true } ]
}
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
==========================================
- Coverage 84.61% 83.33% -1.29%
==========================================
Files 15 15
Lines 1261 1158 -103
Branches 198 191 -7
==========================================
- Hits 1067 965 -102
- Misses 72 73 +1
+ Partials 122 120 -2
Continue to review full report at Codecov.
|
This PR upgrades deps across the repo in preparation for bringing into the ethereumjs-vm monorepo.