block: replace cmp with their gt/lt equivalent

ethereumjs · Oct 29, 2020 · 34fa3ea · 34fa3ea
1 parent 6d69a53
commit 34fa3ea
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/packages/block/src/header.ts b/packages/block/src/header.ts
@@ -280,7 +280,7 @@ export class BlockHeader {
       let a = blockTs.sub(parentTs).idivn(9).ineg().iaddn(uncleAddend)
       const cutoff = new BN(-99)
       // MAX(cutoff, a)
-      if (cutoff.cmp(a) === 1) {
+      if (cutoff.gt(a)) {
         a = cutoff
       }
       dif = parentDif.add(offset.mul(a))
@@ -309,15 +309,13 @@ export class BlockHeader {
       let a = blockTs.sub(parentTs).idivn(10).ineg().iaddn(1)
       const cutoff = new BN(-99)
       // MAX(cutoff, a)
-      if (cutoff.cmp(a) === 1) {
+      if (cutoff.gt(a)) {
         a = cutoff
       }
       dif = parentDif.add(offset.mul(a))
     } else {
       // pre-homestead
-      if (
-        parentTs.addn(common.paramByHardfork('pow', 'durationLimit', hardfork)).cmp(blockTs) === 1
-      ) {
+      if (parentTs.addn(common.paramByHardfork('pow', 'durationLimit', hardfork)).gt(blockTs)) {
         dif = offset.add(parentDif)
       } else {
         dif = parentDif.sub(offset)
@@ -329,7 +327,7 @@ export class BlockHeader {
       dif.iadd(new BN(2).pow(exp))
     }
 
-    if (dif.cmp(minimumDifficulty) === -1) {
+    if (dif.lt(minimumDifficulty)) {
       dif = minimumDifficulty
     }
 
@@ -419,7 +417,7 @@ export class BlockHeader {
 
       if (height) {
         const dif = height.sub(header.number)
-        if (!(dif.cmpn(8) === -1 && dif.cmpn(1) === 1)) {
+        if (!(dif.ltn(8) && dif.gtn(1))) {
           throw new Error('uncle block has a parent that is too old or too young')
         }
       }