devp2p -> snappy: more user friendly RLPx protocol version checks

ethereumjs · Aug 17, 2021 · 892c71c · 892c71c
1 parent 61b0511
commit 892c71c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/packages/devp2p/src/eth/index.ts b/packages/devp2p/src/eth/index.ts
@@ -235,7 +235,7 @@ export class ETH extends EventEmitter {
     let payload = rlp.encode(this._status as any)
 
     // Use snappy compression if peer supports DevP2P >=v5
-    if ((this._peer._hello?.protocolVersion ?? 0) >= 5) {
+    if (this._peer._hello?.protocolVersion && this._peer._hello?.protocolVersion >= 5) {
       payload = snappy.compress(payload)
     }
 
@@ -284,7 +284,7 @@ export class ETH extends EventEmitter {
     payload = rlp.encode(payload)
 
     // Use snappy compression if peer supports DevP2P >=v5
-    if ((this._peer._hello?.protocolVersion ?? 0) >= 5) {
+    if (this._peer._hello?.protocolVersion && this._peer._hello?.protocolVersion >= 5) {
       payload = snappy.compress(payload)
     }
 

diff --git a/packages/devp2p/src/les/index.ts b/packages/devp2p/src/les/index.ts
@@ -171,7 +171,7 @@ export class LES extends EventEmitter {
     let payload = rlp.encode(statusList)
 
     // Use snappy compression if peer supports DevP2P >=v5
-    if ((this._peer._hello?.protocolVersion ?? 0) >= 5) {
+    if (this._peer._hello?.protocolVersion && this._peer._hello?.protocolVersion >= 5) {
       payload = snappy.compress(payload)
     }
 
@@ -231,7 +231,7 @@ export class LES extends EventEmitter {
     payload = rlp.encode(payload)
 
     // Use snappy compression if peer supports DevP2P >=v5
-    if ((this._peer._hello?.protocolVersion ?? 0) >= 5) {
+    if (this._peer._hello?.protocolVersion && this._peer._hello?.protocolVersion >= 5) {
       payload = snappy.compress(payload)
     }
 

diff --git a/packages/devp2p/src/rlpx/peer.ts b/packages/devp2p/src/rlpx/peer.ts
@@ -504,7 +504,7 @@ export class Peer extends EventEmitter {
       let payload = body.slice(1)
 
       // Use snappy uncompression if peer supports DevP2P >=v5
-      if ((this._hello?.protocolVersion ?? 0) >= 5) {
+      if (this._hello?.protocolVersion && this._hello?.protocolVersion >= 5) {
         payload = snappy.uncompress(payload)
       }