Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors occuring in beforeBlock,afterBlock event handlers are treated as invalid blocks #62

Closed
kumavis opened this issue Apr 21, 2016 · 2 comments

Comments

@kumavis
Copy link
Member

kumavis commented Apr 21, 2016

https://github.com/ethereumjs/ethereumjs-vm/blob/19a83f71d913a0e7c96d851c0ed192a9fba5a479/lib/runBlock.js#L50-L56

no error is thrown -- these errors can be simple typos, makes it hard to debug

vm.on('afterBlock', function(block){
  // typo or other accidentally error
  throw new Error()
})
@axic
Copy link
Member

axic commented Feb 1, 2018

What do you propose?

Note, this behaviour is shared with all the other events in the vm.

@holgerd77
Copy link
Member

Open for > 2 years with no one picking it up, will close for now.

holgerd77 added a commit to holgerd77/ethereumjs-vm that referenced this issue Nov 30, 2020
holgerd77 pushed a commit that referenced this issue Dec 1, 2020
holgerd77 added a commit that referenced this issue Dec 14, 2020
Add package-lock.json to .gitignore
holgerd77 added a commit that referenced this issue May 26, 2023
Add comprehensive test coverage for fromV3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants