[WIP] Introduce modexp precompile (EIP101) #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs to be updated, but will be needed for metropolis support. |
|
The message format and the gas formula has changed substantially in the EIP. |
|
Hi @axic, will you have time to update this pull request for the |
axic
changed the title
|
Superseded by #161. |
ryanio
added a commit
that referenced
this pull request
Jan 10, 2022
* rlp: add invalid tests from ethereum/tests * rlp: remove empty string as invalid input * rlp: additional error checks * tidy tests * improve safeSlice error message return statement in else block can be placed outside if statement (https://eslint.org/docs/rules/no-else-return) * tidy * rlp: add cases from Geth * rlp: tests: cleanup * rlp: tests: fix description * rlp: tests: create invalid test file * rlp: dataTypes: increase getLength coverage * rlp: check and remove uncovered lines * Apply suggestions from code review two nits * clarify error messages * Update test/dataTypes.spec.ts Co-authored-by: acolytec3 <17355484+acolytec3@users.noreply.github.com> * Update test/official.spec.ts Co-authored-by: acolytec3 <17355484+acolytec3@users.noreply.github.com> * lint * fix one more deprecated equal * tests: change deprecated methods to their new variants Co-authored-by: Ryan Ghods <ryan@ryanio.com> Co-authored-by: acolytec3 <17355484+acolytec3@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements ethereum/EIPs#198.