Special treatment of value in DELEGATECALL (as per Yellow Paper Section 8) #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…account when a DELEGATECALL is invoked from a payable function. Section 8 of yellow paper Note that we need to differentiate between the value that is to be transferred, v, from the value apparent in the execution context, ˜v, for the DELEGATECALL instruction.
|
Duplicate of #84. |
|
Cool thanks - I can close this. Will the current fix be in a release soon? |
holgerd77
pushed a commit
that referenced
this pull request
Dec 14, 2020
* rename Trie.prove to Trie.createProof tidy up typedoc * regen docs * add pr to changelog * move export type up
This was referenced Apr 7, 2022
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change avoids incorrectly deducting value from the caller's account when a
DELEGATECALLis invoked from apayablefunction (issue).From Section 8 of yellow paper:
Note that we need to differentiate between the value that is to be transferred, v, from the value apparent in the execution context, ˜v, for the DELEGATECALL instruction.