Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monorepo: Client preparing Releases #1491

Merged
merged 24 commits into from
Sep 27, 2021
Merged

Conversation

holgerd77
Copy link
Member

Releases preparing for the client release next week, still WIP.

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #1491 (f8017ba) into master (36d4a06) will increase coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

Flag Coverage Δ
block 86.60% <ø> (ø)
blockchain 82.78% <ø> (ø)
client 84.18% <ø> (+0.74%) ⬆️
common 94.08% <ø> (ø)
devp2p 82.90% <ø> (ø)
ethash 90.71% <ø> (ø)
tx 87.47% <ø> (+0.12%) ⬆️
vm 79.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

packages/block/README.md Outdated Show resolved Hide resolved
@ryanio
Copy link
Contributor

ryanio commented Sep 24, 2021

This new chrome extension I've been using Grammarly has really been really beneficial in helping me to find typos and grammar improvements 😃

ryanio
ryanio previously approved these changes Sep 24, 2021
Copy link
Contributor

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🚀

ryanio
ryanio previously approved these changes Sep 25, 2021
acolytec3
acolytec3 previously approved these changes Sep 25, 2021
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor wording niggle in a suggestion but this looks great!

Co-authored-by: acolytec3 <17355484+acolytec3@users.noreply.github.com>
@ryanio ryanio dismissed stale reviews from acolytec3 and themself via c2da8bb September 25, 2021 15:11
ryanio
ryanio previously approved these changes Sep 25, 2021
Copy link
Contributor

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some more leftover tiny fixes this morning to catch up on them as they are relatively harmless :)

@holgerd77
Copy link
Member Author

Thanks for the review and the additional changes, will now merge here and do the releases. 😄

@holgerd77 holgerd77 merged commit cf95e04 into master Sep 27, 2021
@holgerd77 holgerd77 deleted the client-preparing-releases branch September 27, 2021 09:50
@holgerd77
Copy link
Member Author

Just released the following versions on npm:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants