Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: skip _runStepHook method if no step event listener #1676

Merged
merged 2 commits into from
Feb 1, 2022
Merged

vm: skip _runStepHook method if no step event listener #1676

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2a9905
vm: skip `_runStepHook` method if no step event listener
acolytec3 Jan 31, 2022
b2c8375
Merge branch 'master' into skip-runStepHook
holgerd77 Feb 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/vm/src/evm/interpreter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,11 @@ export default class Interpreter {
await dynamicGasHandler(this._runState, gas, this._vm._common)
}

await this._runStepHook(gas, gasLimitClone)
if (this._vm.listenerCount('step') > 0) {
// Only run this stepHook function if there is an event listener (e.g. test runner)
// since its sole purpose is to emit the step event which is not used anywhere else
await this._runStepHook(gas, gasLimitClone)
}

// Check for invalid opcode
if (opInfo.name === 'INVALID') {
Expand Down