proper error objects on callbacks #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
reviewed
Aug 18, 2017
package.json
Outdated
| @@ -21,12 +21,13 @@ | |||
| "ethereumjs-blockchain": "^1.4.1", | |||
| "ethereumjs-testing": "https://github.com/ethereumjs/ethereumjs-testing", | |||
| "ethereumjs-tx": "1.3.3", | |||
| "install": "^0.10.1", | |||
There was a problem hiding this comment.
A mistake, I removed it
|
Can you please split the linter change into a different PR? |
|
@axic sure, let me split them |
julianduque
force-pushed
the
proper-errors
branch
from
a6a9bd2 to
63fc6be
Compare
julianduque
force-pushed
the
proper-errors
branch
from
63fc6be to
a318fc4
Compare
julianduque
changed the title
axic
approved these changes
Aug 21, 2017
evertonfraga
added a commit
to evertonfraga/ethereumjs-vm
that referenced
this pull request
Dec 16, 2019
Run gh actions on external PRs
holgerd77
pushed a commit
that referenced
this pull request
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a best practice to pass an error object to a callback instead of a string.
In this pull request I updated standard (to catch this errors in the future) and removed an unnecessaryreturnstatement (reported bystandard).