Avoid double-callbacks in CALL

[axic]

This fixes test case Call50000_identity.

[axic]

Explanation: the actual call is moved into the successful-case of accountIsEmpty. The way to trigger two callbacks is if the account is empty and thus newAccountGas applies, but deducting that triggers an OOG. In this case the actual call still happens resulting in a double callback.

[axic]

This change also enables turning back on a lot of tests, the skip list would need to be reduced to

const skip = [
  'CALLCODE_Bounds', // Uses >270Mb of memory
  'CALL_Bounds', // Uses >270Mb of memory
  'CREATE_Bounds', // Uses >270Mb of memory
  'DELEGATECALL_Bounds', // Uses >270Mb of memory
  'mload32bitBound_return2', // Uses too much memory
  'RevertDepthCreateAddressCollision', // test case is wrong
]

I believe those memory ones could be fixed by #174.

[holgerd77]

Looks good to me. This looks generally cleaner to me having the code execution in a deterministic order.

[axic]

@jwasinger @holgerd77 @cdetrio anybody merging this? :)

[holgerd77]

@axic I though that there is an in progress label attached, therefore I waited, has this some other meaning than the [WIP] pre-string?

[axic]

@holgerd77 I don't know how that label ended up there, but no, this is finished.

[holgerd77]

Can you rebase this?

[axic]

@holgerd77 done

[holgerd77]

Looks good