Minor pre Byzantium release 2.2.2 to prevent 2.2.x breaking on ethereumjs-block update #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR narrows down the
ethereumjs-blockdependency inpackage.jsonto~1.6.0from^1.2.2to keep the dependency version in the1.6.xrange once a1.7.0Byzantium release comes out (with changes to block difficulty). The PR has to be accompanied with a minorethereumjs-vm2.2.2release (with a date added to the changelog file).Rationale:
Once a Byzantium-compatible
ethereumjs-blocklibrary is released, the2.2.x(pre-Byzantium) series ofethereumjs-vminstall will immediately break (by auto-installing the Byzantium-compatibleethereumjs-blocklibrary). This is unfavorable especially in the testing/transition period of Byzantium, when people still might want to install the older version of the library.