Tx: Throw when hash() is called on unsigned legacy transaction #1894
Conversation
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Not sure if the changes made to tests inputValue.spec.ts were the right move, or if they should be deleted or changed. With the changes to tx.hash(), those tests now fail. I changed them to expect that Error, but that failure is tested in legacy.spec.ts, so doing it again in this test is redundant. Do we like we're losing something by deleting the two tests in inputValue.spec.ts? |
There was a problem hiding this comment.
Nice, from my side this can get an approval, really clean "catches" of the respective areas to adopt and/or delete the code, I would say the way the tests are adopted are also ok.
Will put this as "Blocked" for now so that we can first merge in #1892 before anything else on develop.
holgerd77
force-pushed
the
tx-legacy-unsigned-throw
branch
from
2621ccf to
e9714a0
Compare
|
@jochem-brouwer yes. 🙂 Rebased this via UI after local test rebase. |
* tx: edit legacyTransaction to throw when hash() called on unsigned tx * tx: adapt legacy.spec test to throw on unsigned tx.hash() * tx: edit tests which call hash() on unsigned tx
* tx: edit legacyTransaction to throw when hash() called on unsigned tx * tx: adapt legacy.spec test to throw on unsigned tx.hash() * tx: edit tests which call hash() on unsigned tx
* tx: edit legacyTransaction to throw when hash() called on unsigned tx * tx: adapt legacy.spec test to throw on unsigned tx.hash() * tx: edit tests which call hash() on unsigned tx
* tx: edit legacyTransaction to throw when hash() called on unsigned tx * tx: adapt legacy.spec test to throw on unsigned tx.hash() * tx: edit tests which call hash() on unsigned tx
* tx: edit legacyTransaction to throw when hash() called on unsigned tx * tx: adapt legacy.spec test to throw on unsigned tx.hash() * tx: edit tests which call hash() on unsigned tx
#1890
Part of #1717