client: Provide txPool.txsByPriceAndNonce with correct vm for fetching txs to build block #2333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g11tech
added
PR state: merge ready
package: client
target: master
…g txs to build block
g11tech
force-pushed
the
g11tech/fix-txsBy-vm
branch
from
354ad75 to
54a623d
Compare
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the txpool.txsByPriceAndNonce filter transaction based on txpool's vm's eei, which could be different from the eei/statemanager which is building the block (and set to different root).
This lead to exclusion of subsequent transactions build on top of previous one in the
shandongtestnet experiments (#2316)This PR passes the correct vm to apply to filter the transactions from the pool.
Test case for this will be automatically included in the
shandongsim test which builds consecutive transactions on same address.