Fix nonce problem #2404
Merged
Fix nonce problem #2404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jochem-brouwer
added
PR state: WIP
PR state: do-not-merge
PR/Issue state: blocked
package: vm
type: test all hardforks
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
jochem-brouwer
force-pushed
the
fix-nonce-problem
branch
from
1739806 to
3f34eff
Compare
jochem-brouwer
force-pushed
the
fix-nonce-problem
branch
from
3f34eff to
f17c49c
Compare
|
OK, for some reason the CI goes out-of-memory on ShanghaiLove test, but only on Homestead fork. It is not clear to me why any changes to this nonce logic should influence this, but OFC this has to be solved. |
acolytec3
approved these changes
Dec 2, 2022
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2022 EthereumJS Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2399
Do not merge, as I just realized when creating this PR why we had this nonce stuff change in the first place and why we had lengthy discussions. Discussion goes into #2399
Note: this rollbacks the changes made to EVM/VM source of #2383 (I consider this rather hacky), but it keeps the tests of that PR.